From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdCd-0007NL-A0
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 14:55:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdCT-0000bE-AK
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 14:55:47 -0400
Received: from mail-yh0-x233.google.com ([2607:f8b0:4002:c01::233]:50208)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdCS-0000b5-Q9
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 14:55:36 -0400
Received: by mail-yh0-f51.google.com with SMTP id t59so1150360yho.10
	for <qemu-devel@nongnu.org>; Fri, 27 Sep 2013 11:55:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5245D4A3.8070603@twiddle.net>
Date: Fri, 27 Sep 2013 11:55:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-18-git-send-email-agraf@suse.de>
In-Reply-To: <1380242934-20953-18-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/60] AArch64: Add dup GPR->Vec
	instruction emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, qemu-devel@nongnu.org, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 09/26/2013 05:48 PM, Alexander Graf wrote:
> +    case 0x0e:
> +        if (!get_bits(insn, 31, 1) && !get_bits(insn, 29, 1) &&
> +            (get_bits(insn, 10, 6) == 0x3)) {
> +            handle_dupg(s, insn);

Is this really better than (insn & y) == x ?


r~