From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50981)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdwH-00068w-Cj
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 15:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdw8-00070h-W2
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 15:42:57 -0400
Received: from mail-yh0-x22e.google.com ([2607:f8b0:4002:c01::22e]:39305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPdw8-00070b-Rg
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 15:42:48 -0400
Received: by mail-yh0-f46.google.com with SMTP id c41so1142972yho.19
	for <qemu-devel@nongnu.org>; Fri, 27 Sep 2013 12:42:48 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5245DFB4.6050500@twiddle.net>
Date: Fri, 27 Sep 2013 12:42:44 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-30-git-send-email-agraf@suse.de>
In-Reply-To: <1380242934-20953-30-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, qemu-devel@nongnu.org, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 09/26/2013 05:48 PM, Alexander Graf wrote:
> +    if (setflags) {
> +        tcg_dst = cpu_reg(dest);
> +    } else {
> +        tcg_dst = cpu_reg_sp(dest);
> +    }

Never sp for logicals.

> +            handle_orri(s, insn);

And yet again, a better function name.


r~