From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPezO-0000oO-VP
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 16:50:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPezG-0000jO-IM
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 16:50:14 -0400
Received: from mail-yh0-x233.google.com ([2607:f8b0:4002:c01::233]:57894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPezG-0000io-Ei
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 16:50:06 -0400
Received: by mail-yh0-f51.google.com with SMTP id t59so1198556yho.24
	for <qemu-devel@nongnu.org>; Fri, 27 Sep 2013 13:50:05 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5245EF79.9020803@twiddle.net>
Date: Fri, 27 Sep 2013 13:50:01 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-41-git-send-email-agraf@suse.de>
In-Reply-To: <1380242934-20953-41-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 40/60] AArch64: Add tbz instruction
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, qemu-devel@nongnu.org, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 09/26/2013 05:48 PM, Alexander Graf wrote:
> +    tcg_cmp = tcg_temp_new_i64();
> +    tcg_mask = tcg_const_i64(mask);
> +    tcg_gen_and_i64(tcg_cmp, cpu_reg(source), tcg_mask);
> +
> +    no_match = gen_new_label();
> +    if (is_one) {
> +        tcg_gen_brcond_i64(TCG_COND_NE, tcg_cmp, tcg_mask, no_match);
> +    } else {
> +        tcg_gen_brcond_i64(TCG_COND_EQ, tcg_cmp, tcg_mask, no_match);
> +    }

You'd do better to brcond vs zero after the and.


r~