From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPgfy-00016a-Kd
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 18:38:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPgfq-0002bP-6h
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 18:38:18 -0400
Received: from mail-yh0-x232.google.com ([2607:f8b0:4002:c01::232]:62083)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VPgfq-0002b7-1b
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 18:38:10 -0400
Received: by mail-yh0-f50.google.com with SMTP id a41so1221358yho.37
	for <qemu-devel@nongnu.org>; Fri, 27 Sep 2013 15:38:09 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <524608CD.7000508@twiddle.net>
Date: Fri, 27 Sep 2013 15:38:05 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-4-git-send-email-agraf@suse.de>
	<524590BC.3050004@twiddle.net>
In-Reply-To: <524590BC.3050004@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/60] arm: Split VFP cmp from FPSCR setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, qemu-devel@nongnu.org, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 09/27/2013 07:05 AM, Richard Henderson wrote:
> On 09/26/2013 05:47 PM, Alexander Graf wrote:
>> -DEF_HELPER_3(vfp_cmps, void, f32, f32, env)
>> -DEF_HELPER_3(vfp_cmpd, void, f64, f64, env)
>> -DEF_HELPER_3(vfp_cmpes, void, f32, f32, env)
>> -DEF_HELPER_3(vfp_cmped, void, f64, f64, env)
>> +DEF_HELPER_3(vfp_fpscr_cmps, void, f32, f32, env)
>> +DEF_HELPER_3(vfp_fpscr_cmpd, void, f64, f64, env)
>> +DEF_HELPER_3(vfp_fpscr_cmpes, void, f32, f32, env)
>> +DEF_HELPER_3(vfp_fpscr_cmped, void, f64, f64, env)
>> +DEF_HELPER_3(vfp_cmps, i32, f32, f32, env)
>> +DEF_HELPER_3(vfp_cmpd, i32, f64, f64, env)
>> +DEF_HELPER_3(vfp_cmpes, i32, f32, f32, env)
>> +DEF_HELPER_3(vfp_cmped, i32, f64, f64, env)
> 
> While you're changing these, please change them to use DEF_HELPER_FLAGS_*.
> For the fpscr helpers, TCG_CALL_NO_RWG (since they have the side effect of
> setting the fpscr); for the new helpers, TCG_CALL_NO_RWG_SE since there are
> no side effects at all.

Actually I forgot the side effect of setting exception bits because
of the comparison.  So TCG_CALL_NO_RWG for both.


r~