[Qemu-devel] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

[Qemu-devel] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

[Stefan Weil]

>From buildbot default_i386_rhel61:

  CC    alpha-softmmu/hw/alpha/typhoon.o
hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

I used lower case 'ull' because the rest of the code writes it that way
although I personally prefer 0xfffffffffffULL to 0xfffffffffffull.

Stefan

 hw/alpha/typhoon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c
index aac9a32..59e1bb8 100644
--- a/hw/alpha/typhoon.c
+++ b/hw/alpha/typhoon.c
@@ -700,7 +700,7 @@ static IOMMUTLBEntry typhoon_translate_iommu(MemoryRegion *iommu, hwaddr addr)
             }
         }
 
-        if (addr >= 0x80000000000 && addr <= 0xfffffffffff) {
+        if (addr >= 0x80000000000ull && addr <= 0xfffffffffffull) {
             /* Check the fourth window for DAC enable and window enable.  */
             if ((pchip->win[3].wba & 0x80000000001ull) == 0x80000000001ull) {
                 uint64_t pte_addr;
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

[Richard Henderson]

On 09/29/2013 08:51 AM, Stefan Weil wrote:
>>From buildbot default_i386_rhel61:
> 
>   CC    alpha-softmmu/hw/alpha/typhoon.o
> hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
> hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
> hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---

Acked-by: Richard Henderson <rth@twiddle.net>


r~

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

[Michael Tokarev]

29.09.2013 19:51, Stefan Weil wrote:
>  From buildbot default_i386_rhel61:
>
>    CC    alpha-softmmu/hw/alpha/typhoon.o
> hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
> hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
> hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type

Thanks, applied to the trivial patches queue.

> I used lower case 'ull' because the rest of the code writes it that way
> although I personally prefer 0xfffffffffffULL to 0xfffffffffffull.

Yea, "full" looks a bit odd here :)

/mjt