* [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
@ 2013-09-08 7:39 Guenter Roeck
2013-09-08 7:51 ` Peter Maydell
2013-09-14 4:04 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Guenter Roeck @ 2013-09-08 7:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Guenter Roeck, Peter Maydell
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from 0x18
Aborted
Reported-and-analyzed-by: Rob Landley <rob@landley.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it
into qemu.
hw/char/sh_serial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
index 6223a55..9328dd1 100644
--- a/hw/char/sh_serial.c
+++ b/hw/char/sh_serial.c
@@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
s->flags &= ~SH_SERIAL_FLAG_RDF;
}
break;
-#if 0
case 0x18:
ret = s->fcr;
break;
-#endif
case 0x1c:
ret = s->rx_cnt;
break;
--
1.7.9.7
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
2013-09-08 7:39 [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2 Guenter Roeck
@ 2013-09-08 7:51 ` Peter Maydell
2013-09-08 15:48 ` Guenter Roeck
2013-09-14 4:04 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2013-09-08 7:51 UTC (permalink / raw)
To: Guenter Roeck, Aurelien Jarno; +Cc: Paolo Bonzini, QEMU Developers
On 8 September 2013 08:39, Guenter Roeck <linux@roeck-us.net> wrote:
> With Linux kernel version 3.3 or later, qemu fails with the following message:
>
> sh_serial: unsupported read from 0x18
> Aborted
>
> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
> for Rob's analysis of the problem. Unfortunately, the patch never made it
> into qemu.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
since I see from that mail thread that I did check the hardware
docs. CCing Aurelien as the listed maintainer for sh4.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
2013-09-08 7:51 ` Peter Maydell
@ 2013-09-08 15:48 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2013-09-08 15:48 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, QEMU Developers, Aurelien Jarno
On 09/08/2013 12:51 AM, Peter Maydell wrote:
> On 8 September 2013 08:39, Guenter Roeck <linux@roeck-us.net> wrote:
>> With Linux kernel version 3.3 or later, qemu fails with the following message:
>>
>> sh_serial: unsupported read from 0x18
>> Aborted
>>
>> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
>> for Rob's analysis of the problem. Unfortunately, the patch never made it
>> into qemu.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> since I see from that mail thread that I did check the hardware
> docs. CCing Aurelien as the listed maintainer for sh4.
>
I did run the patch through get_maintainer.pl, but Aurelien was not listed.
Turns out the file is not listed in MAINTAINERS as belonging to sh4.
Should I submit another patch to fix that ?
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
2013-09-08 7:39 [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2 Guenter Roeck
2013-09-08 7:51 ` Peter Maydell
@ 2013-09-14 4:04 ` Guenter Roeck
2013-09-29 19:12 ` Paolo Bonzini
1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2013-09-14 4:04 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Paolo Bonzini, Aurelien Jarno, qemu-devel, Peter Maydell
On 09/08/2013 12:39 AM, Guenter Roeck wrote:
> With Linux kernel version 3.3 or later, qemu fails with the following message:
>
> sh_serial: unsupported read from 0x18
> Aborted
>
> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
ping ...
> ---
> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
> for Rob's analysis of the problem. Unfortunately, the patch never made it
> into qemu.
>
> hw/char/sh_serial.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
> index 6223a55..9328dd1 100644
> --- a/hw/char/sh_serial.c
> +++ b/hw/char/sh_serial.c
> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
> s->flags &= ~SH_SERIAL_FLAG_RDF;
> }
> break;
> -#if 0
> case 0x18:
> ret = s->fcr;
> break;
> -#endif
> case 0x1c:
> ret = s->rx_cnt;
> break;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
2013-09-14 4:04 ` Guenter Roeck
@ 2013-09-29 19:12 ` Paolo Bonzini
2013-09-29 19:52 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2013-09-29 19:12 UTC (permalink / raw)
To: Guenter Roeck
Cc: Peter Maydell, qemu-trivial, Michael Tokarev, qemu-devel,
Aurelien Jarno
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
> On 09/08/2013 12:39 AM, Guenter Roeck wrote:
>> With Linux kernel version 3.3 or later, qemu fails with the following
>> message:
>>
>> sh_serial: unsupported read from 0x18
>> Aborted
>>
>> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> ping ...
>
>> ---
>> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
>> for Rob's analysis of the problem. Unfortunately, the patch never made it
>> into qemu.
>>
>> hw/char/sh_serial.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
>> index 6223a55..9328dd1 100644
>> --- a/hw/char/sh_serial.c
>> +++ b/hw/char/sh_serial.c
>> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque,
>> hwaddr offs,
>> s->flags &= ~SH_SERIAL_FLAG_RDF;
>> }
>> break;
>> -#if 0
>> case 0x18:
>> ret = s->fcr;
>> break;
>> -#endif
>> case 0x1c:
>> ret = s->rx_cnt;
>> break;
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
2013-09-29 19:12 ` Paolo Bonzini
@ 2013-09-29 19:52 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-09-29 19:52 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Peter Maydell, qemu-devel, Guenter Roeck
29.09.2013 23:12, Paolo Bonzini wrote:
> sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
> as well.
>
> Paolo
>
> Il 14/09/2013 06:04, Guenter Roeck ha scritto:
>> On 09/08/2013 12:39 AM, Guenter Roeck wrote:
>>> With Linux kernel version 3.3 or later, qemu fails with the following
>>> message:
>>>
>>> sh_serial: unsupported read from 0x18
>>> Aborted
>>>
>>> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ping ...
>>
>>> ---
>>> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
>>> for Rob's analysis of the problem. Unfortunately, the patch never made it
>>> into qemu.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-29 19:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-08 7:39 [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2 Guenter Roeck
2013-09-08 7:51 ` Peter Maydell
2013-09-08 15:48 ` Guenter Roeck
2013-09-14 4:04 ` Guenter Roeck
2013-09-29 19:12 ` Paolo Bonzini
2013-09-29 19:52 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).