From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Fam Zheng <famz@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
kraxel@redhat.com, alex@alex.org.uk, pbonzini@redhat.com,
vilanova@ac.upc.edu, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v11 3/8] rule.mak: allow per object cflags and libs
Date: Mon, 30 Sep 2013 13:56:48 +0800 [thread overview]
Message-ID: <524912A0.8070600@linux.vnet.ibm.com> (raw)
In-Reply-To: <1379408075-12685-4-git-send-email-famz@redhat.com>
Some code are spent for nest case since the build system
does not support subdir Makefile. It would be nice if
qemu can change the build system like kernel's build system one
day, then we can avoid these troubles.
The code looks fine.
Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
next prev parent reply other threads:[~2013-09-30 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 8:54 [Qemu-devel] [PATCH v11 0/8] Shared Library Module Support Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 2/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 3/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-30 5:56 ` Wenchao Xia [this message]
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 5/8] module: implement module loading Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-17 8:54 ` [Qemu-devel] [PATCH v11 8/8] block: convert block drivers linked with libs to modules Fam Zheng
2013-09-26 13:26 ` [Qemu-devel] [PATCH v11 0/8] Shared Library Module Support Fam Zheng
2013-10-04 14:48 ` Stefan Hajnoczi
2013-10-04 15:09 ` Michael Tokarev
2013-10-04 15:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524912A0.8070600@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=alex@alex.org.uk \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).