From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQWTw-0001pW-Ku for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQWTn-0006dK-3N for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:57:20 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:49371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQWTm-0006d0-I1 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:57:11 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Sep 2013 15:57:05 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 9C8F52BB0053 for ; Mon, 30 Sep 2013 15:56:57 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8U5dxIm56361112 for ; Mon, 30 Sep 2013 15:40:03 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8U5uqNm021395 for ; Mon, 30 Sep 2013 15:56:53 +1000 Message-ID: <524912A0.8070600@linux.vnet.ibm.com> Date: Mon, 30 Sep 2013 13:56:48 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1379408075-12685-1-git-send-email-famz@redhat.com> <1379408075-12685-4-git-send-email-famz@redhat.com> In-Reply-To: <1379408075-12685-4-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 3/8] rule.mak: allow per object cflags and libs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, kraxel@redhat.com, alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net Some code are spent for nest case since the build system does not support subdir Makefile. It would be nice if qemu can change the build system like kernel's build system one day, then we can avoid these troubles. The code looks fine. Reviewed-by: Wenchao Xia