From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQWUz-0002ef-J2 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:58:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQWUo-0006lU-Kt for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:58:25 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:58225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQWUo-0006lA-2j for qemu-devel@nongnu.org; Mon, 30 Sep 2013 01:58:14 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Sep 2013 15:58:07 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id C28022BB0053 for ; Mon, 30 Sep 2013 15:58:03 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8U5fI0I3342654 for ; Mon, 30 Sep 2013 15:41:18 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8U5w2KS023140 for ; Mon, 30 Sep 2013 15:58:03 +1000 Message-ID: <524912E7.2030807@linux.vnet.ibm.com> Date: Mon, 30 Sep 2013 13:57:59 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 0/7] export internal snapshot by qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com ÓÚ 2013/9/26 8:16, Wenchao Xia дµÀ: > This series allow user to read internal snapshot's contents without qemu-img > convert. > > V2: > Address Stefan's comments: > 02: add 'fall through' comments in the case statement. > 03: add doc about the difference of internal snapshot and backing chain > snapshot, which is used in previous '--snapshot' parameter. > Other: > 01,04: rebased on upstream with conflict resolved. > > v3: > Address Paolo's comments: > 02: add parameter "-l snapshot_id_or_name", rename options > snapshot-load to load-snapshot, use QemuOpts. > 03: rename snapshot-load to load-snapshot. > 04: related change to test both -l and -L case. > 05-07: add similar parameter for qemu-img convert. > Other: > 01: foldered original snapshot logic into function > bdrv_snapshot_load_tmp_by_id_or_name(), since multiple > caller present in this version. Refined error message from > ", reason: %s" to ": %s". > 02: Refined error message from ", reason: %s" to ": %s". > 03: Rename PARAM to SNAPSHOT_PARAM. > > Wenchao Xia (7): > 1 snapshot: distinguish id and name in load_tmp > 2 qemu-nbd: support internal snapshot export > 3 qemu-nbd: add doc for internal snapshot export > 4 qemu-iotests: add 058 internal snapshot export with qemu-nbd case > 5 qemu-img: add -L for snapshot in convert > 6 qemu-img: add doc for param -L in convert > 7 qemu-iotests: add test for snapshot in qemu-img convert > > block/qcow2-snapshot.c | 16 +++++- > block/qcow2.h | 5 ++- > block/snapshot.c | 76 +++++++++++++++++++++++++++- > include/block/block_int.h | 4 +- > include/block/snapshot.h | 13 ++++- > qemu-img-cmds.hx | 2 +- > qemu-img.c | 32 +++++++++--- > qemu-img.texi | 7 ++- > qemu-nbd.c | 46 ++++++++++++++++- > qemu-nbd.texi | 11 ++++- > tests/qemu-iotests/058 | 121 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/058.out | 44 ++++++++++++++++ > tests/qemu-iotests/check | 1 + > tests/qemu-iotests/group | 1 + > 14 files changed, 359 insertions(+), 20 deletions(-) > create mode 100755 tests/qemu-iotests/058 > create mode 100644 tests/qemu-iotests/058.out > Any commenst for this simple series? :)