From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check
Date: Mon, 30 Sep 2013 10:07:44 +0200 [thread overview]
Message-ID: <52493150.7090404@redhat.com> (raw)
In-Reply-To: <20130930080611.GB2507@dhcp-200-207.str.redhat.com>
On 2013-09-30 10:06, Kevin Wolf wrote:
> Am 30.09.2013 um 08:59 hat Max Reitz geschrieben:
>> If an inactive L1 table is loaded from disk, its entries are in big
>> endian and have to be converted to host byte order before using them.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> Sounds like there's yet a test case missing? (But it requires the
> runtime options for enabling these checks, obviously)
Yes to both. For now, I just couldn't write such a test case.
Max
next prev parent reply other threads:[~2013-09-30 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 6:59 [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check Max Reitz
2013-09-30 8:06 ` Kevin Wolf
2013-09-30 8:07 ` Max Reitz [this message]
2013-10-02 9:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52493150.7090404@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).