From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQYWM-0000wG-Vk for qemu-devel@nongnu.org; Mon, 30 Sep 2013 04:08:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQYWE-0001D3-95 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 04:07:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQYWE-0001Cx-1e for qemu-devel@nongnu.org; Mon, 30 Sep 2013 04:07:50 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8U87mYf024513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Sep 2013 04:07:49 -0400 Message-ID: <52493150.7090404@redhat.com> Date: Mon, 30 Sep 2013 10:07:44 +0200 From: Max Reitz MIME-Version: 1.0 References: <1380524368-3283-1-git-send-email-mreitz@redhat.com> <20130930080611.GB2507@dhcp-200-207.str.redhat.com> In-Reply-To: <20130930080611.GB2507@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 2013-09-30 10:06, Kevin Wolf wrote: > Am 30.09.2013 um 08:59 hat Max Reitz geschrieben: >> If an inactive L1 table is loaded from disk, its entries are in big >> endian and have to be converted to host byte order before using them. >> >> Signed-off-by: Max Reitz > Reviewed-by: Kevin Wolf > > Sounds like there's yet a test case missing? (But it requires the > runtime options for enabling these checks, obviously) Yes to both. For now, I just couldn't write such a test case. Max