From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQZMk-0008HL-Kx for qemu-devel@nongnu.org; Mon, 30 Sep 2013 05:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQZMd-0008Ic-0x for qemu-devel@nongnu.org; Mon, 30 Sep 2013 05:02:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQZMc-0008IY-Pm for qemu-devel@nongnu.org; Mon, 30 Sep 2013 05:01:58 -0400 Message-ID: <52493E0E.1060308@redhat.com> Date: Mon, 30 Sep 2013 11:02:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1380465657-22600-1-git-send-email-marcel.a@redhat.com> <20130929150613.GA19383@redhat.com> <1380528896.3439.2.camel@localhost.localdomain> <20130930085815.GA20291@redhat.com> In-Reply-To: <20130930085815.GA20291@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.crosthwaite@xilinx.com, stefanha@redhat.com, Marcel Apfelbaum , sw@weilnetz.de, jasowang@redhat.com, "qemu-devel@nongnu.org" , dkoch@verizon.com, alex.williamson@redhat.com, paul@codesourcery.com, anthony@codemonkey.ws, afaerber@suse.de, kraxel@redhat.com Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: >>> > > As a next step, can we make pci_set_irq non-inline and make >>> > > it call pci_irq_handler directly, and get rid of the irq field? >> > What irq field? > /* IRQ objects for the INTA-INTD pins. */ > qemu_irq *irq; > That's still used by devices that use common code for PCI and sysbus versions (e.g. USB OHCI and EHCI). Paolo