From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQfhY-0007Qd-P6 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQfhS-0004IQ-PG for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:48:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQfhS-0004IH-HR for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:47:54 -0400 Message-ID: <52499D33.9020603@redhat.com> Date: Mon, 30 Sep 2013 17:48:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378956318-23395-1-git-send-email-pingfank@linux.vnet.ibm.com> <1378956318-23395-3-git-send-email-pingfank@linux.vnet.ibm.com> <20130928195635.GC1051@redhat.com> <20130929041547.GA28242@redhat.com> <20130930090631.GC20291@redhat.com> <52493F28.5090303@redhat.com> <20130930093000.GE20291@redhat.com> In-Reply-To: <20130930093000.GE20291@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Anthony Liguori , Jan Kiszka , liu ping fan , qemu-devel@nongnu.org, Stefan Hajnoczi , =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: > I was really only talking about q35 here. > I thought it's ugly that users can control intcap > directly. Can object_set_property be used after > qdev_try_create? Yes, after that and before qdev_init. This is how Ping Fan is doing PIIX right now. > PIIX has another issue: > the default value in hpet is really Q35 specific, > that's also kind of ugly, isn't it? Yeah, perhaps it is. So are you suggesting the default to be 4 (GSI2 only)? Paolo