From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VQfpI-0003GQ-Vo
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:56:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VQfpB-000715-Lz
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:56:00 -0400
Received: from cantor2.suse.de ([195.135.220.15]:44981 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VQfpB-00070y-G6
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:55:53 -0400
Message-ID: <52499F06.20903@suse.de>
Date: Mon, 30 Sep 2013 17:55:50 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1380452123-5989-1-git-send-email-mst@redhat.com>
	<1380452123-5989-2-git-send-email-mst@redhat.com>
	<20130930151056.32699e7f@nial.usersys.redhat.com>
	<20130930144050.GB22806@redhat.com>
	<CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
	<20130930155044.GA10306@redhat.com>
In-Reply-To: <20130930155044.GA10306@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Igor Mammedov <imammedo@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 30.09.2013 17:50, schrieb Michael S. Tsirkin:
> On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote:
>> On 30 September 2013 23:40, Michael S. Tsirkin <mst@redhat.com> wrote:
>>> diff --git a/include/qapi/error.h b/include/qapi/error.h
>>> index 7d4c696..b85e996 100644
>>> --- a/include/qapi/error.h
>>> +++ b/include/qapi/error.h
>>> @@ -13,14 +13,15 @@
>>>  #define ERROR_H
>>>
>>>  #include "qemu/compiler.h"
>>> +#include "qemu/typedefs.h"
>>>  #include "qapi-types.h"
>>>  #include <stdbool.h>
>>>
>>>  /**
>>> - * A class representing internal errors within QEMU.  An error has a=
 ErrorClass
>>> + * Error:
>>> + * An object representing internal errors within QEMU.  An error has=
 a ErrorClass
>>>   * code and a human message.
>>>   */
>>> -typedef struct Error Error;
>>
>> Does the process-doc-comments tool really cope with documentation comm=
ents
>> that are completely separate from the typedef like this?
>>
>> thanks
>> -- PMM
>=20
> Do we care?
> Downstreams don't seem to package it, most people probably use
> editor tags anyway ...
> If yes we can put this all in #if 0.

Can we turn the typedef into just struct Error here? The doc comment can
be applied to either.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg