From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQfy0-0005MP-HR for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQfxv-0001SE-L0 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:05:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQfxv-0001S8-Bm for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:04:55 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8UG4sLi011559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Sep 2013 12:04:54 -0400 Message-ID: <5249A125.4080904@redhat.com> Date: Mon, 30 Sep 2013 10:04:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379938162-14005-1-git-send-email-mreitz@redhat.com> <1379938162-14005-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1379938162-14005-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xI6qMx1C7hbTj07DEQQDqE2f4hsLWiB4r" Subject: Re: [Qemu-devel] [PATCH v5 1/6] qapi: Add ImageInfoSpecific type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xI6qMx1C7hbTj07DEQQDqE2f4hsLWiB4r Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a new type ImageInfoSpecific as a union for image format specific > information in ImageInfo. >=20 > Signed-off-by: Max Reitz > --- > qapi-schema.json | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > @@ -238,6 +250,9 @@ > # > # @backing-image: #optional info of the backing image (since 1.6) > # > +# @info-string: #optional string supplying additional format-specific s/string/struct/ With that one word fixed, I'm fine with: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xI6qMx1C7hbTj07DEQQDqE2f4hsLWiB4r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSaElAAoJEKeha0olJ0NqyYsIAJquQlggSLJYTDZOArRTZIM/ MDIkH1Vzp5TY3RXNy5zfK6Jmt3Dm8E097MnZocfWTkBgeuLXz55DtzNpmQiUlefa JGi2pzQ9JBQoXZWxgR18CsLtnesSY9IFVmMu2opS33/XOUcQJLGqV2XBgJJMdoBa mwJW8gFpVR5rTAfHCWndyw4r1fofuj0visSq6CBIaC5dpVyQM0OzGpW7QXQ4Stgv m/H1o06eD75AGMPQnx/3QaKhbrzhjbE5vtbBAzX5DbqJpslImvRkOOQdYsdWetTO 2wUXE7zpPEqunztfT6Cp91iamo9xB3LKQ9DT1EM5nJWWx4ATwrstRWr7XP2S7m4= =S95N -----END PGP SIGNATURE----- --xI6qMx1C7hbTj07DEQQDqE2f4hsLWiB4r--