From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQh8M-0001yc-QM for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:19:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQh8H-0002Vk-Tp for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:19:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQh8H-0002VW-H3 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:19:41 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8UHJeBn010298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Sep 2013 13:19:41 -0400 Message-ID: <5249B2AB.6090701@redhat.com> Date: Mon, 30 Sep 2013 11:19:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379938162-14005-1-git-send-email-mreitz@redhat.com> <1379938162-14005-7-git-send-email-mreitz@redhat.com> In-Reply-To: <1379938162-14005-7-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Lfhiq4vxAdBQCEAdeeHHrerpOsqO0NKT" Subject: Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Lfhiq4vxAdBQCEAdeeHHrerpOsqO0NKT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a test for the additional information now provided by qemu-img info= > when used on qcow2 images. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/065 | 72 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/065.out | 22 ++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 95 insertions(+) > create mode 100755 tests/qemu-iotests/065 > create mode 100644 tests/qemu-iotests/065.out This patch only tests human output, not JSON. > +# creator > +owner=3Dmreitz@redhat.com > + > +seq=3D`basename $0` > +echo "QA output created by $seq" > + > +here=3D`pwd` Not your fault (copy-and-paste from other tests), but as long as we are requiring bash, $PWD is much faster than `pwd`, and $() is nicer than `` where we don't have even faster shortcuts like $PWD. > +=3D=3D=3D Testing qcow2 image with -o compat=3D0.10 =3D=3D=3D > + > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864=20 > +Format specific information: > +compat: 0.10 Should we be indenting the human output, to make it obvious how many remaining fields are being output as a result of format specific information? I'm still not happy with 5/6 in its current form, but can live with this patch as-is if we don't bother with testing JSON form. Does 5/6 even need to worry about stripping JSON form, if you aren't going to test JSON form? Depending on the answer to that question: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2Lfhiq4vxAdBQCEAdeeHHrerpOsqO0NKT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSbKrAAoJEKeha0olJ0NqzaMIAJAfo+qTevBHGt6nlFSK0nMT /nHXThkYaWOBgBFRjYeEz1dNZ70gaDpfJQZoB82r4lWNYrgBE3nN0jimLcs4MT9g 4Dmdj/0br21KAD4zrZgaahEKEbhl0b2/OaRHIauIWIiC+8GjruG5/QKHpFAGmiRy 1sfjESnZ6Vxv+Trpu+MfIbc1yPFL/FgMpiiLWc0rOM0s7rCbj2nuap0BGRPXBwn2 J8GR11nI7SzO2KkQo4Fd5sZSUykOH3+7ilA9QAUZ8+sFpFraDhYvEsbWGnpXmw0y 09R443Ff5fyByhrQTMUlW6P1h+mzMEE2jKIslKhi1Pm1DoCHF98b6lWYi41gyBw= =6Izs -----END PGP SIGNATURE----- --2Lfhiq4vxAdBQCEAdeeHHrerpOsqO0NKT--