From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQh96-0002yN-9M for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQh91-0002wy-6x for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:20:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQh90-0002wq-Tf for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:20:27 -0400 Message-ID: <5249B2D6.9080905@redhat.com> Date: Mon, 30 Sep 2013 11:20:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1378695482-29805-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1378695482-29805-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kJilQEHfHDuaEkFmukS9fHipIdIE8e4G2" Subject: Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kJilQEHfHDuaEkFmukS9fHipIdIE8e4G2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/08/2013 08:57 PM, Wenchao Xia wrote: > If it is not restored after qcow2_write_snapshots() fail, a core > dump will happen in bdrv_close() since access of invalid pointer. >=20 > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kJilQEHfHDuaEkFmukS9fHipIdIE8e4G2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSbLWAAoJEKeha0olJ0Nq4o4IAJqbShk26g6L19PKQdhwDRnY 5Gj8DlqR0VpPEQHj1N3i4o5hGieRFEeIW0mNMypMjM1Czg6NWgWXoDikQOkmQIsm +jay0yD2H8TojSUBQdq2jm+b1Y2Uhli6nvzM7E/9K2cpCsFSOTcg0Aw9Bdhw9Gbj QJDcZV16RdUeqjxDqct9yOYhTcllkzdu2P/or97XDmxYScZNQimj+LJsupA3+lxk o1ct/vNpizW6QGKw7Mmdu04q5q5ny9UJlV1jBZwSr2KdyeqQXvp5GMZaCDDYorgI 6/ReUATCP67OuebUlvNcSDBC8d4KH6GRS96QogWd2FeC/jGOu+OUPHq/n6rJ75A= =t2e0 -----END PGP SIGNATURE----- --kJilQEHfHDuaEkFmukS9fHipIdIE8e4G2--