From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQhSz-0002b8-2P for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQhSr-0002mn-Og for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:41:05 -0400 Message-ID: <5249B7A5.1000703@suse.de> Date: Mon, 30 Sep 2013 19:40:53 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1378369007-958-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1378369007-958-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <87y56kdi30.fsf@linux.vnet.ibm.com> In-Reply-To: <87y56kdi30.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH -V4 1/4] target-ppc: Update slb array with correct index values. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: qemu-ppc@nongnu.org, paulus@samba.org, qemu-devel@nongnu.org On 09/25/2013 05:41 PM, Aneesh Kumar K.V wrote: > Hi Alex, > > Any update on this ? The patch itself never made it to the qemu-devel mailing list which I pull things off of (through patchworks). Please resend. Alex > > -aneesh > > "Aneesh Kumar K.V" writes: > >> From: "Aneesh Kumar K.V" >> >> Without this, a value of rb=0 and rs=0 results in replacing the 0th >> index. This can be observed when using gdb remote debugging support. >> >> (gdb) x/10i do_fork >> 0xc000000000085330: Cannot access memory at address 0xc000000000085330 >> (gdb) >> >> This is because when we do the slb sync via kvm_cpu_synchronize_state, >> we overwrite the slb entry (0th entry) for 0xc000000000085330 >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> target-ppc/kvm.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c >> index 30a870e..1838465 100644 >> --- a/target-ppc/kvm.c >> +++ b/target-ppc/kvm.c >> @@ -1033,9 +1033,22 @@ int kvm_arch_get_registers(CPUState *cs) >> >> /* Sync SLB */ >> #ifdef TARGET_PPC64 >> + /* >> + * The packed SLB array we get from KVM_GET_SREGS only contains >> + * information about valid entries. So we flush our internal >> + * copy to get rid of stale ones, then put all valid SLB entries >> + * back in. >> + */ >> + memset(env->slb, 0, sizeof(env->slb)); >> for (i = 0; i< 64; i++) { >> - ppc_store_slb(env, sregs.u.s.ppc64.slb[i].slbe, >> - sregs.u.s.ppc64.slb[i].slbv); >> + target_ulong rb = sregs.u.s.ppc64.slb[i].slbe; >> + target_ulong rs = sregs.u.s.ppc64.slb[i].slbv; >> + /* >> + * Only restore valid entries >> + */ >> + if (rb& SLB_ESID_V) { >> + ppc_store_slb(env, rb, rs); >> + } >> } >> #endif >> >> -- >> 1.8.1.2 >