From: Richard Henderson <rth@twiddle.net>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP
Date: Mon, 30 Sep 2013 12:48:14 -0700 [thread overview]
Message-ID: <5249D57E.2040003@twiddle.net> (raw)
In-Reply-To: <5249BF37.50000@suse.de>
On 09/30/2013 11:13 AM, Alexander Graf wrote:
>> - int cpu_num;
>> + union {
>> + uint64_t cpuid;
>> + struct {
>> +#ifdef HOST_WORDS_BIGENDIAN
>> + uint32_t cpu_num;
>> + uint32_t machine_type;
>> +#else
>> + uint32_t machine_type;
>> + uint32_t cpu_num;
>> +#endif
>
> Are we guaranteed that we don't need to pack? Also anonymous unions/structs are
> a gcc extension IIRC. And why do you swap endianness here, but not above when
> defining the machine_type value?
(1) I can't imagine that we would; such struct/unions are used all over.
(2) Sure, but we've so many other gcc extensions I figured it didn't matter.
(3) Of course. I want host endianness, not target endianness.
r~
next prev parent reply other threads:[~2013-09-30 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 14:04 [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env Richard Henderson
2013-09-30 18:03 ` Alexander Graf
2013-09-30 19:15 ` Richard Henderson
2013-10-01 15:48 ` Alexander Graf
2013-10-01 15:52 ` Richard Henderson
2013-10-01 15:54 ` Alexander Graf
2013-10-01 15:56 ` Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 02/10] target-s390: Implement STFLE Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 03/10] target-s390: Add facilities bits and sets Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 04/10] target-s390: Raise OPERATION exception for disabled insns Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 05/10] target-s390: Implement SAM31 and SAM64 Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 06/10] target-s390: Implement EPSW Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP Richard Henderson
2013-09-30 18:13 ` Alexander Graf
2013-09-30 19:48 ` Richard Henderson [this message]
2013-10-01 15:52 ` Alexander Graf
2013-10-01 15:54 ` Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 08/10] target-s390: Fix STURA Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 09/10] target-s390: Implement LURA, LURAG, STURG Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 10/10] target-s390: Implement ECAG Richard Henderson
2013-09-30 18:19 ` [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5249D57E.2040003@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).