From: Stefan Weil <sw@weilnetz.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)
Date: Mon, 30 Sep 2013 22:53:33 +0200 [thread overview]
Message-ID: <5249E4CD.1050605@weilnetz.de> (raw)
In-Reply-To: <871u46iq96.fsf@blackfin.pond.sub.org>
Am 30.09.2013 11:59, schrieb Markus Armbruster:
> Stefan Weil <sw@weilnetz.de> writes:
>> Am 29.09.2013 22:13, schrieb Michael Tokarev:
>>> 29.09.2013 19:41, Stefan Weil wrote:
>>>> The QEMU buildbot default_i386_debian_6_0 shows this warning:
>>>>
>>>> CC migration.o
>>>> migration.c: In function 'qmp_query_migrate_capabilities':
>>>> migration.c:149: warning:
>>>> 'caps' may be used uninitialized in this function
>>> Gah, how disgusting. The code is correct, yet gcc complains
>>> needlessly...
>> That's not the first time where we help the compiler by modifying the code.
> It's also not the first time where attempting to "help" the compiler
> made code less readable, or even less correct. So let's be just as
> careful as with "real" changes.
Well, I try to do my best. ;-)
Is there anything wrong with my patch? I think the code looks cleaner
than before.
If there is a better way to fix the problem that's fine, too.
The problem withthe buildbot showing a compiler warning exists and we
should fix it somehow.
Regards,
Stefan
next prev parent reply other threads:[~2013-09-30 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 15:41 [Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized) Stefan Weil
2013-09-29 20:13 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-09-29 20:33 ` Stefan Weil
2013-09-30 9:59 ` Markus Armbruster
2013-09-30 20:53 ` Stefan Weil [this message]
2013-10-01 8:07 ` Markus Armbruster
2013-10-02 19:02 ` Michael Tokarev
2013-10-02 20:24 ` Stefan Weil
2013-10-03 8:13 ` Paolo Bonzini
2013-10-05 9:15 ` Michael Tokarev
2013-10-05 9:19 ` Michael Tokarev
2013-10-05 9:36 ` Stefan Weil
2013-10-01 11:39 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5249E4CD.1050605@weilnetz.de \
--to=sw@weilnetz.de \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).