From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQlDs-0004Kx-RV for qemu-devel@nongnu.org; Mon, 30 Sep 2013 17:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQlDn-000738-JO for qemu-devel@nongnu.org; Mon, 30 Sep 2013 17:41:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQlDn-00072x-AC for qemu-devel@nongnu.org; Mon, 30 Sep 2013 17:41:39 -0400 Message-ID: <5249F00F.6020200@redhat.com> Date: Mon, 30 Sep 2013 15:41:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1378695482-29805-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1378695482-29805-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cLQISCLRDai0oepUDc7UM4BT4jMxkhSkc" Subject: Re: [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cLQISCLRDai0oepUDc7UM4BT4jMxkhSkc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/08/2013 08:58 PM, Wenchao Xia wrote: > For those error paths which can't be triggered by other debug event, > use snapshot debug events. >=20 > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) >=20 Reviewed-by: Eric Blake I would have squashed 4 and 5 into a single patch (declaring the enums doesn't add any functionality without the event actually using the enum values, and neither patch is so large in isolation where combining them would ips the balance towards too large). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cLQISCLRDai0oepUDc7UM4BT4jMxkhSkc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSfAPAAoJEKeha0olJ0NqRsAIAJgTMAljgeo6CUdw/Mvf2uY5 adpIShVZALnqQjZwO0HhzMQuML57OKSpA6l9o3+2HNOgieSXzmACmHjtuxDjy/gw 3ipPqTV9tdiYC8lQQlfKiigI5i6xXcmAH3G8V/ujwNVeUhb0qGyta9X/Nzp1UkoR bLaw1klHSwsBaVE/z/5449cuZcIO1gkiqZYg9aZ6E92ePdmqDFO1S6963QmlmvWi y18hLd5wC6zk9sJidjc/OM8QWB2EeOnCiDLQhPDZ5jIhvW6z+X1voCXvzb4jNk1B qkzdY5U14KWI1RQcj3d4L48xMsGg169zMI9n5dl5fV6cSktD2U3/TQvsJ1zqZ5I= =FBy7 -----END PGP SIGNATURE----- --cLQISCLRDai0oepUDc7UM4BT4jMxkhSkc--