From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQlll-0005vL-47 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:16:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQllg-00013l-Kp for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:16:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQllg-00013d-Cn for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:16:40 -0400 Message-ID: <5249F842.8050405@redhat.com> Date: Mon, 30 Sep 2013 16:16:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380485683-4626-1-git-send-email-junqing.wang@cs2c.com.cn> <1380485683-4626-3-git-send-email-junqing.wang@cs2c.com.cn> In-Reply-To: <1380485683-4626-3-git-send-email-junqing.wang@cs2c.com.cn> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cjdACHmmPAdIrpjqAOsmPUkK075A0vvSm" Subject: Re: [Qemu-devel] [PATCH v2 2/4] Curling: cmdline interface. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jules Wang Cc: pbonzini@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cjdACHmmPAdIrpjqAOsmPUkK075A0vvSm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/29/2013 02:14 PM, Jules Wang wrote: > Add an option '-f' to migration cmdline. > Indicating whether to enable fault tolerant or not. >=20 > Signed-off-by: Jules Wang > --- > .help =3D "migrate to URI (using -d to not wait for comp= letion)" > "\n\t\t\t -b for migration without shared storage with" > " full copy of disk\n\t\t\t -i for migration without " > "shared storage with incremental copy of disk " > - "(base image shared between src and destination)", > + "(base image shared between src and destination)" > + "\n\t\t\t -f for fault tolerant, this is another " > + "feature rather than migrate", That sounds awkward, and overly long. Maybe go with just: -f for fault tolerance mode and let the user then read the full documentation for what it entails. > -@item migrate [-d] [-b] [-i] @var{uri} > +@item migrate [-d] [-b] [-i] [-f] @var{uri} > @findex migrate > Migrate to @var{uri} (using -d to not wait for completion). > -b for migration with full copy of disk > -i for migration with incremental copy of disk (base image is shared)= > + -f for fault tolerant Can -d and -f be used at the same time, or are they exclusive? > +++ b/hmp.c > @@ -1213,10 +1213,11 @@ void hmp_migrate(Monitor *mon, const QDict *qdi= ct) > int detach =3D qdict_get_try_bool(qdict, "detach", 0); > int blk =3D qdict_get_try_bool(qdict, "blk", 0); > int inc =3D qdict_get_try_bool(qdict, "inc", 0); > + int ft =3D qdict_get_try_bool(qdict, "ft", 0); Why two spaces? > +++ b/qapi-schema.json > @@ -2420,7 +2420,8 @@ > # Since: 0.14.0 > ## > { 'command': 'migrate', > - 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' } } > + 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool', > + '*ft': 'bool' } } Missing documentation, including mention that the new option was only made available in 1.7. We still don't have introspection; is there some other means by which libvirt and other management apps can tell whether this feature is available? Furthermore, 'ft' is an awfully short name; for QMP, we prefer to use full words where possible, such as 'fault-tolerant'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cjdACHmmPAdIrpjqAOsmPUkK075A0vvSm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSfhCAAoJEKeha0olJ0NqXUwH/R4eef3ztmrP24ksizo9UrlG atufmChbsVOalD10W15bKta2qXNVaCHZ4pQGDn1kJTB3VT8HFkdlyi+y+Es/2GtO QtdAfmTsRQVHwdTI8WekfnOucxvlsARsm5NvUf7NMihpL6yAM0uxmgiSKzUwAZIV qKeWO6YuAy+CKWRrbUMvpaM7NdYNKxZw64EEfeUIWGqy7qyHZxkn7Z9/Rt5pjhR3 9Z30KFGMwn3K/h4NjcGUb1l7TJdKUIaLDN0zyK2e/HI7GkG4Lm9KQt5cvjUOqVgO RQ1GtjdB5uEy750rOTdcob1aSObL7tXgfBUr1/cri2Z1d5mWzFQnAenPl0DKnrY= =NUDG -----END PGP SIGNATURE----- --cjdACHmmPAdIrpjqAOsmPUkK075A0vvSm--