From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQlxa-0008UD-Nl for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQlxV-0003zz-Rs for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:28:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQlxV-0003zv-Hz for qemu-devel@nongnu.org; Mon, 30 Sep 2013 18:28:53 -0400 Message-ID: <5249FB21.7000405@redhat.com> Date: Mon, 30 Sep 2013 16:28:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1378695482-29805-8-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1378695482-29805-8-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R09VEMmE48PAIJacR8pwBmQbxvSQfBjaI" Subject: Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R09VEMmE48PAIJacR8pwBmQbxvSQfBjaI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/08/2013 08:58 PM, Wenchao Xia wrote: > This test will focus on the low level procedure of qcow2 snapshot > operations, now it covers only the create operation. Overlap error > paths are not checked since no good way to trigger those errors. >=20 > Signed-off-by: Wenchao Xia > --- > tests/qemu-iotests/063 | 229 ++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/063.out | 37 +++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 267 insertions(+), 0 deletions(-) > create mode 100755 tests/qemu-iotests/063 > create mode 100644 tests/qemu-iotests/063.out >=20 > +# only test qcow2 > +_supported_fmt qcow2 > +_supported_proto generic > +_supported_os Linux > + > +IMGOPTS=3D"compat=3D1.1" > + > +CLUSTER_SIZE=3D65536 > + > +SIZE=3D1G > + > +BLKDBG_TEST_IMG=3D"blkdebug:$TEST_DIR/blkdebug.conf:$TEST_IMG" > + > +errno=3D5 Not all platforms have errno 5 tied to EIO; but then again, you filtered this test to run only on Linux. Is it possible to be a bit more generic, though? At any rate, more tests are always good. I didn't read very closely; but I also didn't see anything obviously wrong with the patch, and it is self-validating whether the testsuite still passes after applying it. So feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --R09VEMmE48PAIJacR8pwBmQbxvSQfBjaI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSfshAAoJEKeha0olJ0NqbTUH/iH0ydpDy294QmD4ZPH+kuYw leuF/fc/Nxz0YhAAXOzQLPhxVy8kupJOR2LRqJMXM7UZ9TkrJf2Ra2QCssROc9Z5 906Ru6j7Og88jjwJZIReeao0F0suUuwKpPWQjUt6JJ7DaTHKvLVnmlxVh7OSNhCr cokN/PTFBp97Wou2E0UKF9QMb8jvJZMDDZ3uhWzDk1DqMzhxgogr+v0e5pkHAsQs NOv540pdUA/1xQnnrBwTWEDaWUYybtKNtfihI7sVnpb5PLmlDyc0S1yiXJ+ch+7I Mo/f/pkhk2NS2uAYNHJpLBRHdfeW3u+7VvNPFwl88NZX/HmIw8lgkWLY+ZRYbKA= =PlVy -----END PGP SIGNATURE----- --R09VEMmE48PAIJacR8pwBmQbxvSQfBjaI--