From: Richard Henderson <rth@twiddle.net>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: peter.maydell@linaro.org, lcapitulino@redhat.com,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
Date: Mon, 30 Sep 2013 19:00:04 -0700 [thread overview]
Message-ID: <524A2CA4.40000@twiddle.net> (raw)
In-Reply-To: <1380556655-22282-4-git-send-email-chouteau@adacore.com>
On 09/30/2013 08:57 AM, Fabien Chouteau wrote:
> +extern const MonitorDef arch_monitor_defs[];
This is supplied by target-foo/monitor.c, right?
Why in the world is it declared in generic code?
Especially if it's only ever accessed via the
cpu->monitor_defs member?
r~
next prev parent reply other threads:[~2013-10-01 2:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:57 [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v3) Fabien Chouteau
2013-09-30 15:57 ` [Qemu-devel] [PATCH 1/4] Fix coding style Fabien Chouteau
2013-09-30 15:57 ` [Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup Fabien Chouteau
2013-09-30 15:57 ` [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array Fabien Chouteau
2013-10-01 1:08 ` Peter Maydell
2013-10-01 14:23 ` Fabien Chouteau
2013-10-01 14:49 ` Peter Maydell
2013-10-01 2:00 ` Richard Henderson [this message]
2013-10-01 14:28 ` Fabien Chouteau
2013-10-01 15:13 ` Richard Henderson
2013-10-01 15:21 ` Peter Maydell
2013-10-01 16:13 ` Fabien Chouteau
2013-09-30 15:57 ` [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands Fabien Chouteau
2013-10-01 1:12 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2013-10-04 16:56 [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v4) Fabien Chouteau
2013-10-04 16:57 ` [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array Fabien Chouteau
2013-10-04 17:49 ` Peter Maydell
2013-10-04 17:55 ` Andreas Färber
2013-10-07 10:11 ` Fabien Chouteau
2013-10-07 11:45 ` Peter Maydell
2013-10-07 13:06 ` Fabien Chouteau
2013-10-07 13:29 ` Peter Maydell
2013-10-07 14:40 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524A2CA4.40000@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=chouteau@adacore.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).