From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50632)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VQpGJ-0004Yk-Pi
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 22:00:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VQpGC-00030y-8r
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 22:00:31 -0400
Received: from mail-gg0-f176.google.com ([209.85.161.176]:37753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VQpGC-00030M-3w
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 22:00:24 -0400
Received: by mail-gg0-f176.google.com with SMTP id s2so549669ggf.35
	for <qemu-devel@nongnu.org>; Mon, 30 Sep 2013 19:00:08 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <524A2CA4.40000@twiddle.net>
Date: Mon, 30 Sep 2013 19:00:04 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380556655-22282-1-git-send-email-chouteau@adacore.com>
	<1380556655-22282-4-git-send-email-chouteau@adacore.com>
In-Reply-To: <1380556655-22282-4-git-send-email-chouteau@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: peter.maydell@linaro.org, lcapitulino@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de

On 09/30/2013 08:57 AM, Fabien Chouteau wrote:
> +extern const MonitorDef arch_monitor_defs[];

This is supplied by target-foo/monitor.c, right?
Why in the world is it declared in generic code?

Especially if it's only ever accessed via the
cpu->monitor_defs member?


r~