Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

[Sebastian Ottlik <ottlik@fzi.de>]

On 23.09.2013 12:33, Sebastian Ottlik wrote:
> On 18.09.2013 18:58, Stefan Weil wrote:
>> Am 16.09.2013 17:10, schrieb Sebastian Ottlik:
>>> On 16.09.2013 16:55, Paolo Bonzini wrote:
>>>> Il 16/09/2013 16:23, Sebastian Ottlik ha scritto:
>>>>> - Added the silent flag to socket_set_fast_reuse controlling error
>>>>> reporting
>>>>>     One location where SO_REUSEADDR was set would report errors if
>>>>> setting the
>>>>>     option failed. Keeping the reporting code there would be somewhat
>>>>> unclean, so
>>>>>     I moved it to socket_set_fast_reuse. A side effect of this was
>>>>> that the error
>>>>>     reporting was added for all locations that now use
>>>>> socket_set_fast_reuse. Here
>>>>>     a new flag is added to control error reporting, which means this
>>>>> patchset
>>>>>     won't change QEMU behaviour (except for not setting SO_REUSEADDR
>>>>> on Windows).
>>>> Is there actually a case where setting SO_REUSEADDR could fail?
>>>>
>>>> Paolo
>>> Yes, but its very unlikely. E.g. the first parameter is not a valid
>>> socket.
>>>
>> If failures only happen when something is very wrong (like an invalid
>> socket id),
>> an assertion might be better, and we could remove the 'silent' 
>> parameter.
>>
>> Stefan
>>
> IMO for debug builds this is a good idea. However, in production use 
> it is probably preferable to keep QEMU running, as a failure won't be 
> too critical. From a quick grep it looks like NDEBUG is not set so 
> assertions wont be removed for non-debug builds. I don't feel 
> acquainted enough with the source code to decide about this kind of 
> change in functionality, which is why I was waiting so long to reply.
ping