From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQzbe-0000Ql-I2 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQzbX-000242-Az for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:03:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQzbX-00023f-29 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:03:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r91CoSWx017411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Oct 2013 08:50:28 -0400 Message-ID: <524AC501.5070904@redhat.com> Date: Tue, 01 Oct 2013 06:50:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380630722-19430-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1380630722-19430-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IFLjGQS2AGmgjUMm7ab0b0ajxtpLTJepo" Subject: Re: [Qemu-devel] [PATCH v6 0/6] Provide additional info through qemu-img info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IFLjGQS2AGmgjUMm7ab0b0ajxtpLTJepo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 06:31 AM, Max Reitz wrote: > qemu-img info provides only pretty general information about an image. > For any image format, there might be specific options which cannot be > represented in a universal way; for instance, qcow2 provides the > compatibility and lazy_refcount options whose values are certainly > interesting but currently cannot be output by qemu-img info. >=20 > Therefore, this series adds a new ImageInfoSpecific union type to > ImageInfo which may be used by block drivers as a template for new type= s > dedicated to the specific information they can provide, as well as a > function bdrv_get_specific_info for retrieving this information. It als= o > adds support to qemu-img info and qemu-io -c info to print the content > of these specific structures. >=20 > v6: > - implemented Eric's remarks: > - corrected description of ImageInfo in qapi-schema.json (patch 1) > - added root indentation in bdrv_image_info_specific_dump (patch 3);= > Although this is a very minor change, I dropped Eric's Reviewed-by= > because of it, since I'm not sure myself whether the place I've > added the indentation is actually the right one (maybe the caller > of bdrv_image_info_specific_dump should control the indentation > instead of hardcoding it into the function). > Furthermore, this (his) suggestion was not part of his review for > this patch, but for patch 6. I think what you did was fine (if we ever have a reason to reuse bdrv_image_info_specific_dump in a new location with different indentation, we could rework it to add an indentation parameter at that time). And I like how the output now looks in the updated 6/6 patch. > - changed patch 5 from using some non-portable expressions to fully > bash-specific ones > - use $() instead of `` and $PWD instead of `pwd` in patch 6 and > indent format specific information in reference output (according > to change in patch 3) > - rebased on Kevin's block branch (changed some line numbers and the > diff environment in patch 5) Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IFLjGQS2AGmgjUMm7ab0b0ajxtpLTJepo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSsUBAAoJEKeha0olJ0NqXZEIAJTxAw+rodef/Tno/n3BDcIJ GRVXA16/gL3PZDB3raya152dzkCVRgyRLJMbyeqPyPpQFSbL8y3DbRLByihYUgJx 8tXGviKJF5af9LwWBbVlugCmttreHf+kOVpsFVPRJjURZUAt9z7JTgLSGJTJ4cVc +NWFINs0laF6g/6bXJk76UfsJLKHB8ZyepOF3aU1741iIzraeahd2t0ao5aD1Orh MRePyG/RK7gDPj29pwa9gXXoRKJpu1TfjS4lVtNAnb6deSRGk7Fttb3RwdxCuSEm vhVEb0xoPL6w3MC+nkseLEArl7iKAqfQk11/+j1srB51/NcZh6Fd49AVl4frX48= =K0nr -----END PGP SIGNATURE----- --IFLjGQS2AGmgjUMm7ab0b0ajxtpLTJepo--