From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR1Lq-0003aD-Jl for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR1Lk-0006mv-Rt for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:55:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR1Lk-0006mo-I3 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:54:56 -0400 Message-ID: <524AE23B.5080606@redhat.com> Date: Tue, 01 Oct 2013 08:54:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HgeaBu2MQhFB9ANUiC3aUV248q8asJreO" Subject: Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HgeaBu2MQhFB9ANUiC3aUV248q8asJreO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Now qemu-img convert have similar options as qemu-nbd for internal > snapshot. >=20 > Signed-off-by: Wenchao Xia > --- > qemu-img.c | 30 +++++++++++++++++++++--------- > 1 files changed, 21 insertions(+), 9 deletions(-) >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 6df58ed..a784ad4 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1140,6 +1140,7 @@ static int img_convert(int argc, char **argv) > int min_sparse =3D 8; /* Need at least 4k of zeros for sparse dete= ction */ > bool quiet =3D false; > Error *local_err =3D NULL; > + QemuOpts *sn_opts =3D NULL; > =20 > fmt =3D NULL; > out_fmt =3D "raw"; > @@ -1148,7 +1149,7 @@ static int img_convert(int argc, char **argv) > compress =3D 0; > skip_create =3D 0; > for(;;) { > - c =3D getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qn"); > + c =3D getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qnL:"); New options should be documented in the same patch that introduces them. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HgeaBu2MQhFB9ANUiC3aUV248q8asJreO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSuI7AAoJEKeha0olJ0NqypEH/RYg+QPw94N1YgxZHVEkgVZE 7e8JckftS13QbqGndsNBoED3nqALdi1G0MpgqNA8YttO44WMLdCvhERhoyn2VPik lulL3USg5Vu9Ahxrdyf6a/H2S5vI/dxFRXGy0ANi6fbyW24uYs7NOevPAd6BS6OW E2N62tB+h6H/ME6bLBLklFiaRFtQ0aYup61xFVq3lJwhvVpk2PnUvLIFEPzDVYUL Uq8HUF3puylqFxZ/NPq7Hv/vfipjt36GyfzxIsm18sP7iYW8Solp+//bBu2rC5np t6F5JdIoNfWsB43EJHMyARZ5yrJKpNJKVEuBfOvTX67Ktu9/Ebz/CiV19G++Ods= =JusF -----END PGP SIGNATURE----- --HgeaBu2MQhFB9ANUiC3aUV248q8asJreO--