From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR1Nt-0005XY-Hg for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:57:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR1Nm-0007wQ-NA for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:57:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR1Nm-0007wD-D9 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:57:02 -0400 Message-ID: <524AE2BA.7090905@redhat.com> Date: Tue, 01 Oct 2013 08:56:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1380154568-5339-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1380154568-5339-7-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="buoWELP12Jwt1Kj8hFsNjgPHbBhJ70fMD" Subject: Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --buoWELP12Jwt1Kj8hFsNjgPHbBhJ70fMD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Also renamed snapshot_name to snapshot_id_or_name to tip better. s/to tip better/as a better hint of what it does/ >=20 > Signed-off-by: Wenchao Xia > --- > qemu-img-cmds.hx | 2 +- > qemu-img.c | 2 ++ > qemu-img.texi | 7 +++++-- > 3 files changed, 8 insertions(+), 3 deletions(-) Squash this into 5/7. > + " 'snapshot_param' is param used for internal snapshot, fo= rmat is\n" > + " 'snapshot.id=3D[ID],snapshot.name=3D[NAME]'\n" Again, can you reuse the existing -s, instead of having to add -L, by making the command line parser smarter about whether it is seeing a single name vs. a string starting with 'snapshot.'? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --buoWELP12Jwt1Kj8hFsNjgPHbBhJ70fMD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSuK6AAoJEKeha0olJ0NqAJ4H/iqQjRMlt9oAvNhrgNDy750b tHONJPzzTypW+NlhIie7E5Xs+ptWCOLn37y4D+p/rrk7ScChg3ThTWkUUG99aSn5 dUwZbZNmb/k9gq5q4nSMxbGj6nxkdTO1vpiCuDACUDCfhSmateY6Sy7AdYLnjY+P P5irxYAqHR30yG7CHCfuth/FuI3O+5odd3r6sfkU38T2Yi5B2vT1TOqcjJeXLpZH nDjWSaQBwyDjCNPLIFaxoqof8u9YpmEZiBreinAGyfuN2xR++ou+B51FWgDL6Mec etWFGNCelLslu0Mkua3Isy4iV9xG5jFsMg3Y0DDkCzbol8SOfP6/WsN9LRio3X4= =daL2 -----END PGP SIGNATURE----- --buoWELP12Jwt1Kj8hFsNjgPHbBhJ70fMD--