From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR24e-0008Sk-Ay for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR24Y-0006kI-1A for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR24X-0006kC-NJ for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:13 -0400 Message-ID: <524AED13.9030000@redhat.com> Date: Tue, 01 Oct 2013 09:41:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="icTktBrF4Vuf8f93Trs65uuGSp54tHAkk" Subject: Re: [Qemu-devel] [PATCH v2 00/17] blockdev-add QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --icTktBrF4Vuf8f93Trs65uuGSp54tHAkk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This series adds a blockdev-add QMP command and a row of cleanup patche= s to > separate legacy -drive/drive_add behaviour from blockdev_init() to the = wrapper > function drive_init(). >=20 > v2: >=20 > - Removed I/O throttling and copy-on-read options from the schema: Both= are > candidates for becoming block filters instead. For the time being, yo= u can > use the existing QMP commands in order to enable I/O throttling on a = device > created with blockdev-add in a second step. Tolerable as a stop-gap; but doesn't that mean that there is a window where throttling is not active? Anything that can restrict block operations must ultimately be specified atomically up front to avoid a non-deterministic burst during the race window. But in the interest of incremental improvements, I can live with the approach used here, while still waiting for throttling to be implemented as a true filter device. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --icTktBrF4Vuf8f93Trs65uuGSp54tHAkk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSu0TAAoJEKeha0olJ0NqeUYH/0hzc3LMm40daqF4/PF9JyxA omWY9rAGQUwQUnludOvGZpNI1YrcQkzBuWRtvWR/oYK+fX4rjfg66UDNwDjnUj7F 2SlcAfTdmzWRPL38hlK4Mkgf+M7FqopLmpQWGdur9LdcAqiCYOkNEW5eBmqZhyIW h9hCvz3jcyb4M3DAsG08TQJbNzBXHjX5mNQVB3+wEvpLLp8DXAHXnptPlrDc4wk/ zIX/21nw2dnZ9zco9Du4MtDqDzWTktevOEps3aSff21GL7+8fAF69E2xMwpkftig SAjNWpyFtblKR9pRv3fadbjmiHawDQRLOTcqoEwrV667iqdakR10VSARcreiy9Y= =Qehg -----END PGP SIGNATURE----- --icTktBrF4Vuf8f93Trs65uuGSp54tHAkk--