From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR24w-0000I6-RH for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR24r-0007BP-PF for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR24r-0007B9-H2 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:41:33 -0400 Message-ID: <524AED26.8000308@redhat.com> Date: Tue, 01 Oct 2013 09:41:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6tcvATlgJ3sOJm2wnid7Fqm8jO2rEjohT" Subject: Re: [Qemu-devel] [PATCH v2 04/17] blockdev: 'blockdev-add' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6tcvATlgJ3sOJm2wnid7Fqm8jO2rEjohT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > For examples see the changes to qmp-commands.hx. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 57 ++++++++++++++ > qapi-schema.json | 236 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qmp-commands.hx | 59 ++++++++++++++ > 3 files changed, 352 insertions(+) >=20 > +# @BlockdevOptionsVVFAT > +# > +# Driver specific block device options for the vvfat protocol. > +# > +# @dir: directory to be exported as FAT image > +# @fat-type: #optional FAT type: 12, 16 or 32 > +# @floppy: #optional whether to export a floppy image (true) or > +# partitioned hard disk (false; default) > +# @rw: #optional whether to allow write operations (default: = false) Aligned across multiple options... > +# @BlockdevOptionsGenericFormat > +# > +# Driver specific block device options for image format that have no o= ption > +# besides their data source. > +# > +# @file: reference to or definition of the data source block de= vice =2E..nothing to compare to here (but aligned with other commands)... > +# @BlockdevOptionsGenericCOWFormat > +# > +# Driver specific block device options for image format that have no o= ption > +# besides their data source and an optional backing file. > +# > +# @backing: #optional reference to or definition of the backing fi= le block > +# device (if missing, taken from the image file content)= =2E It is > +# allowed to pass an empty string here in order to disab= le the > +# default backing file. =2E..and again... > +# Driver specific block device options for qcow2. > +# > +# @lazy-refcounts: #optional whether to enable the lazy refcounts feat= ure > +# (default is taken from the image file) > +# > +# @pass-discard-request: #optional whether discard requests to the qco= w2 device > +# should be forwarded to the data source =2E..but here, using exactly one space (different alignment per option). I honestly don't care which style you use. And while it looks odd having two different styles in the same patch, it really doesn't matter to me, so I'm not asking for a respin just for this (then again, you already have a fix needed in the C code). > +SQMP > +blockdev-add > +------------ > + > +Add a block device. > + > +Arguments: > + > +- "options": block driver options > + > +Example (1): > + > +-> { "execute": "blockdev-add", > + "arguments": { "options" : { "driver": "qcow2", > + "file": { "driver": "file", > + "filename": "test.qcow2" } = } } } > +<- { "return": {} } > + > +Example (2): > + > +-> { "execute": "blockdev-add", > + "arguments": { > + "options": { > + "driver": "qcow2", > + "id": "my_disk", > + "discard": "unmap", > + "throttling": { > + "bps-total": 1234567, > + "iops-write": 100 > + }, Drop throttling, as it is no longer in the qapi. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6tcvATlgJ3sOJm2wnid7Fqm8jO2rEjohT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSu0mAAoJEKeha0olJ0NqzaEH/0R4eeVZQVGFjcdlwfL6cRxZ OGQWyzr3p0RlDz0lzNA/KZ/zWyW/p2ooitda/bb84EOo3OnoNeYnv4HpZUt83yPT I++iggBSOLBaKtnsR2yR9v8OPUbA+FqgUoufW4rn1yn6whU0/36wPgow+Iqn2xOT VQ8j3+Lm4XViFYZx4vwziVsRNV2sR3+rSPbKIEdmcl5TzH6qtUTrKs9+aGB0/Q8q 0TPg16ZLmuwtLpMe7lmkIVO96aL3tG6eCIq14l3yBNJLrFfr/k2pyZFLBmCKgvkr x7x6dvfs9KIZ6/agRttpxfvRGChifbsPP4IbUJRG2pTVPw5P19iJjrf1/+dY1ik= =Mz/g -----END PGP SIGNATURE----- --6tcvATlgJ3sOJm2wnid7Fqm8jO2rEjohT--