From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in convert
Date: Tue, 01 Oct 2013 18:07:34 +0200 [thread overview]
Message-ID: <524AF346.7090900@redhat.com> (raw)
In-Reply-To: <1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com>
Il 26/09/2013 02:16, Wenchao Xia ha scritto:
> + c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qnL:");
> if (c == -1) {
> break;
> }
> @@ -1183,6 +1184,9 @@ static int img_convert(int argc, char **argv)
> case 's':
> snapshot_name = optarg;
> break;
> + case 'L':
> + sn_opts = qemu_opts_parse(&internal_snapshot_opts, optarg, 0);
> + break;
> case 'S':
Should qemu-img introduce -l too, and deprecate -s (continue to accept
it silently, but not document it)?
Paolo
next prev parent reply other threads:[~2013-10-01 16:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 0:16 [Qemu-devel] [PATCH V3 0/7] export internal snapshot by qemu-nbd Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 1/7] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-10-01 14:35 ` Eric Blake
2013-10-10 5:38 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 2/7] qemu-nbd: support internal snapshot export Wenchao Xia
2013-10-01 14:45 ` Eric Blake
2013-10-01 16:08 ` Paolo Bonzini
2013-10-10 6:00 ` Wenchao Xia
2013-10-10 6:12 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 3/7] qemu-nbd: add doc for " Wenchao Xia
2013-10-01 14:49 ` Eric Blake
2013-10-10 6:04 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 4/7] qemu-iotests: add 058 internal snapshot export with qemu-nbd case Wenchao Xia
2013-10-01 14:53 ` Eric Blake
2013-10-10 6:06 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in convert Wenchao Xia
2013-10-01 14:54 ` Eric Blake
2013-10-01 16:07 ` Paolo Bonzini [this message]
2013-10-10 6:07 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L " Wenchao Xia
2013-10-01 14:56 ` Eric Blake
2013-10-10 6:09 ` Wenchao Xia
2013-09-26 0:16 ` [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for snapshot in qemu-img convert Wenchao Xia
2013-10-01 14:57 ` Eric Blake
2013-10-10 6:10 ` Wenchao Xia
2013-09-30 5:57 ` [Qemu-devel] [PATCH V3 0/7] export internal snapshot by qemu-nbd Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524AF346.7090900@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).