From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VR2Tw-0005cZ-LJ
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:07:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VR2Tn-0001KL-7O
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:07:28 -0400
Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:54669)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VR2Tn-0001K8-2q
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:07:19 -0400
Received: by mail-qa0-f50.google.com with SMTP id j7so3476571qaq.2
	for <qemu-devel@nongnu.org>; Tue, 01 Oct 2013 09:07:18 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <524AF346.7090900@redhat.com>
Date: Tue, 01 Oct 2013 18:07:34 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in
	convert
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org

Il 26/09/2013 02:16, Wenchao Xia ha scritto:
> +        c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qnL:");
>          if (c == -1) {
>              break;
>          }
> @@ -1183,6 +1184,9 @@ static int img_convert(int argc, char **argv)
>          case 's':
>              snapshot_name = optarg;
>              break;
> +        case 'L':
> +            sn_opts = qemu_opts_parse(&internal_snapshot_opts, optarg, 0);
> +            break;
>          case 'S':

Should qemu-img introduce -l too, and deprecate -s (continue to accept
it silently, but not document it)?

Paolo