Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On 10/01/2013 07:20 AM, Kevin Wolf wrote:
> This moves all of the geometry options (cyls/heads/secs/trans) to
> drive_init so that they can only be accessed using legacy functions, but
> never with anything blockdev-add related.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c | 136 +++++++++++++++++++++++++++++++------------------------------
>  1 file changed, 69 insertions(+), 67 deletions(-)
> 

> +        },{
> +            .name = "trans",
> +            .type = QEMU_OPT_STRING,
> +            .help = "chs translation (auto, lba. none)",

s/lba\./lba,/

> -        },{
> -            .name = "trans",
> -            .type = QEMU_OPT_STRING,
> -            .help = "chs translation (auto, lba. none)",

Of course, that's just a code motion of an existing typo.  And trivial
enough that it can be fixed by the maintainer without a respin.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]