From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2WE-0007tD-GN for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:09:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR2W9-0001xG-6Z for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:09:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2W8-0001wG-TX for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:09:45 -0400 Message-ID: <524AF3C2.9050309@redhat.com> Date: Tue, 01 Oct 2013 10:09:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4qF10snHF1Q6db6adAlFU7jcBbr1RexEh" Subject: Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4qF10snHF1Q6db6adAlFU7jcBbr1RexEh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This moves all of the geometry options (cyls/heads/secs/trans) to > drive_init so that they can only be accessed using legacy functions, bu= t > never with anything blockdev-add related. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 136 +++++++++++++++++++++++++++++++----------------------= -------- > 1 file changed, 69 insertions(+), 67 deletions(-) >=20 > + },{ > + .name =3D "trans", > + .type =3D QEMU_OPT_STRING, > + .help =3D "chs translation (auto, lba. none)", s/lba\./lba,/ > - },{ > - .name =3D "trans", > - .type =3D QEMU_OPT_STRING, > - .help =3D "chs translation (auto, lba. none)", Of course, that's just a code motion of an existing typo. And trivial enough that it can be fixed by the maintainer without a respin. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4qF10snHF1Q6db6adAlFU7jcBbr1RexEh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSvPDAAoJEKeha0olJ0NqIEoIAI14RWR5WYvDewJfURCXkkMi tzDPoa5NnA6/pNA96HKV9FAtoC9ZsTSIHJmoiCHVy9DrHRB2YCfvFKqTcjC63HPd m1p4nQkOEBZ8smsMeKbC1BvGXU9jfIc4DnQNcUf4gVLwQMPEf7M8kTciBrmE3Xxa HdIjfGIH0TsCtp9q8SEyb6o6k0djFRskcMnM0O5YR41YX31C/8zVYEFNJcmFam5k ns4SAH74C7xwou3Ol+JUp/VWQQYq3L0VdLHiQ1/aUUHJrKWkPZwEcl4yJWIDuA6o UfdBCC+uzXAqfIynOJiwlthUcYDTsjoAqTfmCEGx53Aj2aPC0nzKUbzIszpq87A= =WiYA -----END PGP SIGNATURE----- --4qF10snHF1Q6db6adAlFU7jcBbr1RexEh--