From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VR2a0-00011A-SV
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:13:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VR2Zu-0003V8-To
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:13:44 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:49949
	helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VR2Zu-0003Ul-NY
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:13:38 -0400
Message-ID: <524AF4AF.1010509@adacore.com>
Date: Tue, 01 Oct 2013 18:13:35 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1380556655-22282-1-git-send-email-chouteau@adacore.com>
	<1380556655-22282-4-git-send-email-chouteau@adacore.com>
	<524A2CA4.40000@twiddle.net> <524ADBF3.9090105@adacore.com>
	<524AE694.1030708@twiddle.net>
	<CAFEAcA8ZCkE1p9cz2WNuWynAA7Gvg5ZqzgsUviuaQx3+TYHgeA@mail.gmail.com>
In-Reply-To: <CAFEAcA8ZCkE1p9cz2WNuWynAA7Gvg5ZqzgsUviuaQx3+TYHgeA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 10/01/2013 05:21 PM, Peter Maydell wrote:
> The declaration should go in cpu-qom.h (again, compare
> the gdb stuff), and it should be called "arm_monitor_defs",
> "ppc_monitor_defs" etc, not arch_monitor_defs. (This
> avoids issues if we ever manage to compile more than one
> target CPU into a single qemu binary, and again, it follows
> existing conventions).
>=20

monitor.h drag a lot of thing...

In file included from /home/chouteau/src/qemu-main/include/monitor/monito=
r.h:7:0,
                 from /home/chouteau/src/qemu-main/target-i386/cpu-qom.h:=
26,
                 from /home/chouteau/src/qemu-main/target-i386/cpu.h:917,
                 from /home/chouteau/src/qemu-main/include/qemu-common.h:=
116,
                 from /home/chouteau/src/qemu-main/exec.c:27:
/home/chouteau/src/qemu-main/include/block/block.h:187:59: error: unknown=
 type name =E2=80=98QEMUIOVector=E2=80=99


Maybe MonitorDef can be in a specific file include/monitor/monitordef.h?
included by monitor.c target-*/monitor.c and target-*/cpu.c

--=20
Fabien Chouteau