From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53090)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VR33j-0004f5-Ab
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:44:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VR33b-0005rC-UP
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:44:27 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:38898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VR33b-0005qy-Ng
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 12:44:19 -0400
Message-ID: <524AFBDB.7010206@weilnetz.de>
Date: Tue, 01 Oct 2013 18:44:11 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1379341429-29141-1-git-send-email-ottlik@fzi.de>
	<52371BCB.4090004@redhat.com> <52371F58.1030303@fzi.de>
	<5239DBA8.8070608@weilnetz.de> <5240190E.5050204@fzi.de>
	<524A83A8.3020909@fzi.de>
In-Reply-To: <524A83A8.3020909@fzi.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Ottlik <ottlik@fzi.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Jan Kiszka <jan.kiszka@siemens.com>

Am 01.10.2013 10:11, schrieb Sebastian Ottlik:
> On 23.09.2013 12:33, Sebastian Ottlik wrote:
>> On 18.09.2013 18:58, Stefan Weil wrote:
>>> If failures only happen when something is very wrong (like an invalid
>>> socket id),
>>> an assertion might be better, and we could remove the 'silent'
>>> parameter.
>>>
>>> Stefan
>>>
>> IMO for debug builds this is a good idea. However, in production use
>> it is probably preferable to keep QEMU running, as a failure won't be
>> too critical. From a quick grep it looks like NDEBUG is not set so
>> assertions wont be removed for non-debug builds. I don't feel
>> acquainted enough with the source code to decide about this kind of
>> change in functionality, which is why I was waiting so long to reply.
> ping

Running QEMU with an invalid socket id is not preferable.
It's better to get a dozen of assertions in production and fix the code
than to have hundreds of production systems running with hidden bugs.

Those users who don't agree can build QEMU with -DNDEBUG and use the
close-your-eyes strategy "if error then no error".

Therefore I strongly suggest adding an assertion and removing the
'silent' parameter.

Regards,
Stefan