From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3Qh-0006e3-OX for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR3Qc-0005OW-T8 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:08:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3Qc-0005OG-K1 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:08:06 -0400 Message-ID: <524B0163.7000205@redhat.com> Date: Tue, 01 Oct 2013 11:07:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-16-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-16-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IUCPOmAsWKsXUp75OAScf2AW6eJP1c0hL" Subject: Re: [Qemu-devel] [PATCH v2 15/17] blockdev: Remove 'media' parameter from blockdev_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IUCPOmAsWKsXUp75OAScf2AW6eJP1c0hL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > The remaining users shouldn't be there with blockdev-add and are easy t= o > move to drive_init(). >=20 > Bonus bug fix: As a side effect, CD-ROM drives can now use block driver= s > on the read-only whitelist without explicitly specifying read-only=3Don= , > even if a format is explicitly specified. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > blockdev.c | 40 +++++++++++++++------------------------- > 1 file changed, 15 insertions(+), 25 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IUCPOmAsWKsXUp75OAScf2AW6eJP1c0hL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSwFjAAoJEKeha0olJ0Nqc2kH/jjRgIPrJYj8GDW2mCZHzpDi gocH13xZJ/aBMhVcE56+BWS62KaaFZaJS5cLFEn/duZzfqI3BTzo3EMgfAjUOnnw YrwFJ4krqMocZ/CYZW7SGzIdhKgghFf3kF4JIjfRLnIEXKVosan5O5/V2saMwvaT s+AVA3fk5MaKDHdYOks4UyEMfyhZ5c1L50EkyThcI0/lrxnbA5Dew7Pr/W027ggG whkraFB2HpYdXdQ8FxqxpFrqFigyTwrfjaQIi+17ibdvj9I5Bd2NcIPjCepkr3xe NLey9r5Q1vwjozpAStq81WhTqgfvPlYBRzCJm0FXbE05ihg7jTVpUBrTeVOQhN0= =ZMIF -----END PGP SIGNATURE----- --IUCPOmAsWKsXUp75OAScf2AW6eJP1c0hL--