From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3Ry-0007ll-Ac for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR3Rt-0005gN-Dv for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:09:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3Rt-0005gG-3r for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:09:25 -0400 Message-ID: <524B01BF.2070009@redhat.com> Date: Tue, 01 Oct 2013 11:09:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-17-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-17-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GxWIXJuujlQp0jUW1l7GNDf0AWawv3t2N" Subject: Re: [Qemu-devel] [PATCH v2 16/17] blockdev: Don't disable COR automatically with blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GxWIXJuujlQp0jUW1l7GNDf0AWawv3t2N Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > If a read-only device is configured with copy-on-read=3Don, the old cod= e > only prints a warning and automatically disables copy on read. Make it > a real error for blockdev-add. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block.c | 9 +++++++-- > blockdev.c | 31 +++++++++++++++++++++++++++---- > 2 files changed, 34 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GxWIXJuujlQp0jUW1l7GNDf0AWawv3t2N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSwG/AAoJEKeha0olJ0NqCXYH/0uBoy2mltw7kHNQjm0FMOr7 rnmV5IHcqQgNtDNA1fp2tf8IFycxzSFoZ7Qo3IVZzeb/TsKqummfr6YMnqyeqYbX rfLr+F9FVVyUjt5XeaS09w07WBKbj4XYYXnMDrm7WQzkqqz8xzYnpaw4bk44vrRA g6h7Zzi2ghBagbumT0nqIVAYbCd5HSEnh9RVptd00Xss2JJ7ZW5ZOenUvOs75o5W LbODxE6abkdjJAUEzIZ73lJQMAMDv01djpfcdie1SDM9YEKh58uFSgKIZLjfBwn0 dql+dstdQ/65SqUAY+Zhn7GtwoOk+7cd5BrKmabenlRpzyc/UBwYZnqdT6rQ5qc= =HTYJ -----END PGP SIGNATURE----- --GxWIXJuujlQp0jUW1l7GNDf0AWawv3t2N--