From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3c2-0007Kr-LD for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:19:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR3bw-0000WA-PT for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:19:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR3bw-0000W2-Er for qemu-devel@nongnu.org; Tue, 01 Oct 2013 13:19:48 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r91HJlcf011589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Oct 2013 13:19:47 -0400 Message-ID: <524B0248.6050600@redhat.com> Date: Tue, 01 Oct 2013 11:11:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380542578-2387-1-git-send-email-famz@redhat.com> <1380542578-2387-4-git-send-email-famz@redhat.com> In-Reply-To: <1380542578-2387-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ge555TPnJruKEvFUQb4VCiJtxdI27nepG" Subject: Re: [Qemu-devel] [PATCH v4 3/7] mirror: don't close target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ge555TPnJruKEvFUQb4VCiJtxdI27nepG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/30/2013 06:02 AM, Fam Zheng wrote: > Let reference count manage target and don't call bdrv_close here. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/block/mirror.c b/block/mirror.c > index fdc7fa8..af6851f 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -479,7 +479,6 @@ immediate_exit: > } > bdrv_swap(s->target, s->common.bs); > } > - bdrv_close(s->target); > bdrv_unref(s->target); > block_job_completed(&s->common, ret); > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ge555TPnJruKEvFUQb4VCiJtxdI27nepG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSwJIAAoJEKeha0olJ0Nq00IIAJZKsRK7D9CCtDxpd/kTo7Ki VTkgZlFTZtH4PpUQt5474n4s40ZfA7PWptIuLpxPv5w47+JJQfrCtRoGw3XRrLNP 9RBpVCdzD3LP6nfuoqZE7mfYSjQfzQN2qhtFB4A2HhY4kNgRwE3L5q6Q0nOJmEAT DDtNnXE5kFpo2ZW3r/TZOv7jIxewzkT4LlVtjlzdNNkGYfs8MPEjfGmxh+Dk97wy PxXR54lgani4gG5zkW/klavydCuaiB9bN5G8o3YMkLs0aFzmSJzs1jvVyQMP0wDs TkzuVTw+T+qiIARYSu6dh9KhcQOpgQprQvGruk60XyyiOfsu6r3XBSmuxnfruPI= =WwkF -----END PGP SIGNATURE----- --ge555TPnJruKEvFUQb4VCiJtxdI27nepG--