qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
Cc: Bug 1233225 <1233225@bugs.launchpad.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem
Date: Tue, 01 Oct 2013 22:43:34 +0200	[thread overview]
Message-ID: <524B33F6.8060904@weilnetz.de> (raw)
In-Reply-To: <20131001181451.12751.73694.malone@chaenomeles.canonical.com>

Am 01.10.2013 20:14, schrieb Stefan Weil:
> Here is the related commit found by git bisect:
>
> $ git bisect bad
> 68473f15d4c9948986618f63828825beafcaf1cf is the first bad commit
> commit 68473f15d4c9948986618f63828825beafcaf1cf
> Author: Richard Henderson <rth@twiddle.net>
> Date:   Sun Feb 10 10:30:46 2013 -0800
>
>     mips64-linux-user: Enable 64-bit address mode and fpu
>     
>     Signed-off-by: Richard Henderson <rth@twiddle.net>
>     Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> :040000 040000 de3caa25e43aaeb7d992715b2efc6804a7d0d633
> b007b2a9809547197952ca4d36fbd29f89aab470 M      target-mips
>


Hi Aurelien, hi Richard,

the following patch is a workaround which fixes the reported problem
(see https://bugs.launchpad.net/qemu/+bug/1233225):

diff --git a/target-mips/translate.c b/target-mips/translate.c
index ad43d59..475b0f6 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -15990,7 +15990,7 @@ void cpu_state_reset(CPUMIPSState *env)
     }
     /* Enable 64-bit FPU if the target cpu supports it.  */
     if (env->active_fpu.fcr0 & (1 << FCR0_F64)) {
-        env->CP0_Status |= (1 << CP0St_FR);
+        // env->CP0_Status |= (1 << CP0St_FR);
     }
 #else
     if (env->hflags & MIPS_HFLAG_BMASK) {

Of course it's not the correct solution. I won't be able to look more
into this issue the next days, but maybe you already have a bug fix.

Regards,
Stefan

  reply	other threads:[~2013-10-01 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 15:09 [Qemu-devel] [Bug 1233225] [NEW] mips/mipsel linux user float division problem Johannes Schauer
2013-10-01 17:51 ` [Qemu-devel] [Bug 1233225] " Stefan Weil
2013-10-02  1:39   ` Peter Maydell
2013-10-02  5:22     ` Stefan Weil
2013-10-02 12:58       ` Peter Maydell
2013-10-01 18:14 ` Stefan Weil
2013-10-01 20:43   ` Stefan Weil [this message]
2013-10-02 16:48 ` Johannes Schauer
2013-10-08  0:21 ` Petar Jovanovic
2016-12-06 11:43 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524B33F6.8060904@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=1233225@bugs.launchpad.net \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).