From: Eric Blake <eblake@redhat.com>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: lcapitulino@redhat.com, seiji.aguchi@hds.com,
qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts
Date: Tue, 01 Oct 2013 15:25:17 -0600 [thread overview]
Message-ID: <524B3DBD.8020108@redhat.com> (raw)
In-Reply-To: <20131001210953.23207.28945.stgit@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On 10/01/2013 03:09 PM, Tomoki Sekiyama wrote:
> Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts
> of image files in its disk; e.g.:
>
> # mount | grep ^/
> /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered)
> /tmp/disk.img on /mnt type ext4 (rw,relatime,seclabel)
>
> To avoid the deadlock, this freeze filesystems in reverse order of mounts.
s/freeze/freezes/
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
> qga/commands-posix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thaw already worked in the forward direction; with your patch, this
means thaw undoes the actions by freeze in the opposite order (last
frozen is first thawed), which is also a good thing.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-01 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 21:09 [Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts Tomoki Sekiyama
2013-10-01 21:25 ` Eric Blake [this message]
2013-10-08 20:49 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B3DBD.8020108@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=tomoki.sekiyama@hds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).