From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRO2J-0001as-BN for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:08:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRO2B-000544-3k for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:08:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRO2A-00053o-S7 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:08:15 -0400 Message-ID: <524C36D4.80608@redhat.com> Date: Wed, 02 Oct 2013 09:08:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380723636-18456-1-git-send-email-pl@kamp.de> In-Reply-To: <1380723636-18456-1-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JIrxtCWW1OLHK4975x62QPIuggUU2QP3b" Subject: Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JIrxtCWW1OLHK4975x62QPIuggUU2QP3b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/02/2013 08:20 AM, Peter Lieven wrote: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. however, the raw driver already > has called bdrv_get_block_status on bs->file. >=20 > v4: use a flag to detect the raw driver instead of the strncmp > hack. The v4 designation... >=20 > Signed-off-by: Peter Lieven > --- =2E..should appear after the --- separator (useful to reviewers, but doesn't need to be part of the git history). > block.c | 4 ++-- > block/raw_bsd.c | 6 +++++- > include/block/block.h | 3 +++ > 3 files changed, 10 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JIrxtCWW1OLHK4975x62QPIuggUU2QP3b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSTDbUAAoJEKeha0olJ0Nqma0H/2W1HLzPxS2k8uRlcQelWY39 tP0X1wcwdYcDlIcJqGy/pFdRqmC/yxqHsCJiAW+QC4rzjpxshOxfRDg5zIi3fec3 bXWIzSyUO2LkBRpn74v9uJWRGxRleDnZHPVk7ZqijPMoYI1+VQ4FP53QTN7Sy8vD JI8PJ5c3vIfckvxKcTDrMwKF5n7J6mlP3VZgyn0fn/aSOBqprPeglWTLOkr8cO7D d6Y/4eRBKjpoBavOW4X+ka/d8gGyXgM7GTjbqeE9paiI9HL6OoIXNDM+kY2rI52i jnpP2tX6Ij27FSG4utrEeI9DIrT2rD7O8/taIpseNHAPeMhEMnk6L+66GL6985Y= =bzsy -----END PGP SIGNATURE----- --JIrxtCWW1OLHK4975x62QPIuggUU2QP3b--