From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VROEd-0004oi-WC
	for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:21:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VROEW-0000bc-M4
	for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:21:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VROEW-0000bP-Du
	for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:21:00 -0400
Message-ID: <524C39E2.2080904@redhat.com>
Date: Wed, 02 Oct 2013 17:21:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1380717694-13091-1-git-send-email-marcel.a@redhat.com>
	<1380717694-13091-3-git-send-email-marcel.a@redhat.com>
In-Reply-To: <1380717694-13091-3-git-send-email-marcel.a@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for
 allocating and asserting irqs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, anthony@codemonkey.ws, mst@redhat.com, sw@weilnetz.de, jasowang@redhat.com, qemu-devel@nongnu.org, dkoch@verizon.com, keith.busch@intel.com, alex.williamson@redhat.com, kraxel@redhat.com, stefanha@redhat.com, dmitry@daynix.com, afaerber@suse.de, ehabkost@redhat.com

Il 02/10/2013 14:41, Marcel Apfelbaum ha scritto:
> +static inline void pci_irq_pulse(PCIDevice *pci_dev)
> +{
> +    pci_irq_lower(pci_dev);
> +    pci_irq_raise(pci_dev);
> +}
> +

Why is this in the opposite order, compared to qemu_irq_pulse?

Paolo