qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com,
	"Benoît Canet" <benoit@irqsave.net>,
	stefanha@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot.
Date: Wed, 02 Oct 2013 09:42:33 -0600	[thread overview]
Message-ID: <524C3EE9.2080409@redhat.com> (raw)
In-Reply-To: <524C3CAC.6060308@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On 10/02/2013 09:33 AM, Max Reitz wrote:
> On 2013-10-02 14:33, Benoît Canet wrote:
>> This field is used by blkverify to disable external snapshots creation.
>> I will also be used by block filters like quorum to disable external
>> snapshots
>> creation.
> Oh, I nearly missed it: s/I will also be/It will also be/ and probably
> s/external snapshots creation/external snapshot creation/, but I'm not
> too sure about the last one.

As a native speaker, yes, that last change sounds better ("to disable
external snapshot creation").

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

      reply	other threads:[~2013-10-02 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02 12:33 [Qemu-devel] [PATCH V4] disable blkverify external snapshot creation Benoît Canet
2013-10-02 12:33 ` [Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot Benoît Canet
2013-10-02 15:30   ` Max Reitz
2013-10-09 10:22     ` Kevin Wolf
2013-10-02 15:33   ` Max Reitz
2013-10-02 15:42     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524C3EE9.2080409@redhat.com \
    --to=eblake@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).