From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VROjj-0005Jb-M7 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VROje-0002nc-Ne for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:53:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VROje-0002nG-FN for qemu-devel@nongnu.org; Wed, 02 Oct 2013 11:53:10 -0400 Message-ID: <524C415D.3090802@redhat.com> Date: Wed, 02 Oct 2013 09:53:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380029714-5239-1-git-send-email-pl@kamp.de> <1380029714-5239-7-git-send-email-pl@kamp.de> In-Reply-To: <1380029714-5239-7-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j0t7D35gvcbg470bv6JfLC5MwJoJbAf39" Subject: Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j0t7D35gvcbg470bv6JfLC5MwJoJbAf39 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/24/2013 07:35 AM, Peter Lieven wrote: > this patch adds BlockLimits which introduces discard and write_zeroes > limits and alignment information to the BlockDriverState. >=20 > Signed-off-by: Peter Lieven > --- > include/block/block_int.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > =20 > +struct BlockLimits { Should this be a typedef? Either in include/qemu/typedefs.h (where BlockDriverState is listed), or locally (see BdrvTrackedRequest in the same file for an example)? > @@ -280,6 +294,9 @@ struct BlockDriverState { > uint64_t total_time_ns[BDRV_MAX_IOTYPE]; > uint64_t wr_highest_sector; > =20 > + /* I/O Limits */ > + struct BlockLimits bl; > + All other struct/pointer-to-struct members in BlockDriverState are listed by typedef name, rather than calling out 'struct foo'. My question is one of style/consistency, not of C correctness; so unless a maintainer actually agrees that a typedef change is needed so that you comply with project coding standards, feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --j0t7D35gvcbg470bv6JfLC5MwJoJbAf39 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSTEFdAAoJEKeha0olJ0NqKaUH/0Z5c+kl2oHYjUODb26M4HFM 2TsycsVMGjOH0lTdkaVcAKl+1VkUGCpaOFv1Rw/tE4NpJfArNJ/Zi/lw6yll3eph MB7+G0CNPDc/pyUwA8z6jfYSXFtQWwusXsjhnHQCl9QdcpFoiQzzRiT9J7rJaUpt h0vKiGmLlEKTfPPCtCWAej13VGUAt1QnZXnM/IZsu+ahKTKomV2sqpYCeKsH0Qyv K8ZSlcRu/dhC7uBG5wBT7se9d9lJXAOvwojZ929Od0KQjnt37KkrSY1LSRUXiinz 4pyigRIaBQnVb7vODIUJfjSB/N2b/lp3OwRnly/8tPVjEsUgmGey3v2FDPbOtN4= =MCDo -----END PGP SIGNATURE----- --j0t7D35gvcbg470bv6JfLC5MwJoJbAf39--