From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPQt-0006xx-2z for qemu-devel@nongnu.org; Wed, 02 Oct 2013 12:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRPQi-0000qg-IK for qemu-devel@nongnu.org; Wed, 02 Oct 2013 12:37:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPQi-0000qV-8h for qemu-devel@nongnu.org; Wed, 02 Oct 2013 12:37:40 -0400 Message-ID: <524C4BCB.1070209@redhat.com> Date: Wed, 02 Oct 2013 10:37:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380029714-5239-1-git-send-email-pl@kamp.de> <1380029714-5239-8-git-send-email-pl@kamp.de> In-Reply-To: <1380029714-5239-8-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EMRgqOOBEAHjOXImRuJUqSCFNCJu34UAu" Subject: Re: [Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EMRgqOOBEAHjOXImRuJUqSCFNCJu34UAu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++--------= -------- > 1 file changed, 49 insertions(+), 16 deletions(-) >=20 > diff --git a/block.c b/block.c > index ac35cb5..580570a 100644 > --- a/block.c > +++ b/block.c > @@ -2710,32 +2710,65 @@ int coroutine_fn bdrv_co_copy_on_readv(BlockDri= verState *bs, > BDRV_REQ_COPY_ON_READ); > } > =20 > + > + if (ret =3D=3D -ENOTSUP) { > + /* Fall back to bounce buffer if write zeroes is unsupport= ed */ > + iov.iov_len =3D num * BDRV_SECTOR_SIZE; Why 2 spaces? But that's trivial. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EMRgqOOBEAHjOXImRuJUqSCFNCJu34UAu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSTEvLAAoJEKeha0olJ0NqcxkH/RREsB1ENVKCicTBeyjYO8t0 o9K2KXTamFotWuKW/rF3AocosTxlhQZkq+PR62IaPOlz8jlAyhxQId5c68wITXTo g1NPYuh//dEHZVgd6cKbzAPyTR4i/T/LsNT0lBkqjhGzpKgq7w432i4y32aVoaAj OyHBiyFX/4iz0/rQbeKVRWRiNK4XUCUAqbe7oWAXrCZXa2O4/TQ+Wd9z68e9qAf9 pKVV+O1hPnTS56UM7TxoTMyW3yeVUeRbv2oln+XVvMX/x+e2HgFye6UHpCysinTp +abKOj8g0blE8HWcLWnIJu+er9i0ZPTN6PlCiGN3u7UsTOHGovQdfG0Dh7Msyq4= =7akE -----END PGP SIGNATURE----- --EMRgqOOBEAHjOXImRuJUqSCFNCJu34UAu--