From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQGa-00009o-Is for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQGT-0001MK-5j for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:31:16 -0400 Received: from mga03.intel.com ([143.182.124.21]:27660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQGS-0001LW-UE for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:31:09 -0400 Message-ID: <524C5851.80600@intel.com> Date: Wed, 02 Oct 2013 10:30:57 -0700 From: Alexander Duyck MIME-Version: 1.0 References: <20130228184803.23865.84744.stgit@bling.home> <52460268.3030402@intel.com> <1380733924.14271.92.camel@ul30vt.home> In-Reply-To: <1380733924.14271.92.camel@ul30vt.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ioh3420: Add a map_irq function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, mst@redhat.com On 10/02/2013 10:12 AM, Alex Williamson wrote: > On Fri, 2013-09-27 at 15:10 -0700, Alexander Duyck wrote: >> On 02/28/2013 10:49 AM, Alex Williamson wrote: >>> Every bridge needs to know how to map IRQs from it's secondary bus to >>> the primary bus. We seem to be direct mapped on ioh3420. This avoids >>> segfaults when trying to put assigned devices behind root ports. >>> >>> Signed-off-by: Alex Williamson >>> >>> --- >>> hw/ioh3420.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/hw/ioh3420.c b/hw/ioh3420.c >>> index 95bceb5..6ac4fe7 100644 >>> --- a/hw/ioh3420.c >>> +++ b/hw/ioh3420.c >>> @@ -90,6 +90,11 @@ static void ioh3420_reset(DeviceState *qdev) >>> pci_bridge_disable_base_limit(d); >>> } >>> >>> +static int ioh3420_map_irq(PCIDevice *pci_dev, int irq_num) >>> +{ >>> + return irq_num; >>> +} >>> + >>> static int ioh3420_initfn(PCIDevice *d) >>> { >>> PCIBridge* br = DO_UPCAST(PCIBridge, dev, d); >>> @@ -97,6 +102,8 @@ static int ioh3420_initfn(PCIDevice *d) >>> PCIESlot *s = DO_UPCAST(PCIESlot, port, p); >>> int rc; >>> >>> + pci_bridge_map_irq(br, NULL, ioh3420_map_irq); >>> + >>> rc = pci_bridge_initfn(d); >>> if (rc < 0) { >>> return rc; >>> >> What became of this patch? I believe I am seeing the issue described >> when I assign a MSI-X capable virtual device to the secondary bus of an >> ioh3420, and applying this patch seems to resolve the issue. Was there >> an alternate patch proposed and if so where can I find it? > Hmm, I thought it was no longer necessary with > pci_device_route_intx_to_irq(), especially if you're assigning a VF that > doesn't support INTx. Are you using the latest qemu bits? pci-assign > or vfio-pci? Maybe provide a backtrace? Thanks, > > Alex I'm seeing it with an emulated interface using MSI-X, not with a VF or assigned device. I'll try to get you a backtrack when I have some time. I'm currently chasing down another issue and will try to remember to follow up on this one. Thanks, Alex