Re: [Qemu-devel] [Xen-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

[Fabio Fantoni <fabio.fantoni@m2r.biz>]

Il 25/09/2013 18:12, Pasi Kärkkäinen ha scritto:
> On Sun, Jul 28, 2013 at 05:56:01PM +0100, Frediano Ziglio wrote:
>>     2013/7/23 Gerd Hoffmann <[1]kraxel@redhat.com>
>>
>>       Â  Hi,
>>       > Tested-by: Fabio Fantoni <[2]fabio.fantoni@m2r.biz>
>>       >
>>       > I tested it for a long time with spice on xen (because qxl will be
>>       fully
>>       > working only after adding SSE support on hvm domUs). It works, I think
>>       > it is good to add this and the respective vgabios patch on upstream.
>>
>>       >> Â  Â  Â  Â  Â case VBE_DISPI_INDEX_XRES:
>>       >> - Â  Â  Â  Â  Â  Â if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) ==
>>       0)) {
>>       >> + Â  Â  Â  Â  Â  Â if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) ==
>>       0)) {
>>       >> Â  Â  Â  Â  Â  Â  Â  Â  Â s->vbe_regs[s->vbe_index] = val;
>>       >> Â  Â  Â  Â  Â  Â  Â }
>>       >> Â  Â  Â  Â  Â  Â  Â break;
>>
>>       It's not that simple. Â With 32bit depths common today it will work
>>       fine,
>>       but for lower depths (especially those lower than 8bit) this will give
>>       you broken scanline alignment.
>>
>>       cheers,
>>       Â  Gerd
>>
>>     In the card I tested the scanline is keep aligned but for this reason is
>>     not directly computed by maxx * bits but is something bigger.
>>
> Hmm.. so is an update needed for this patch? It'd be nice to get this patch in!

Ping

Some statistics for evidence the importance to add support for 1366x768 
and other resolutions:
http://www.rapidtables.com/web/dev/screen-resolution-statistics.htm
http://www.geek.com/chips/most-popular-screen-resolution-increases-to-1366-x-768-1482311/

>
> -- Pasi
>   
>>     Frediano
>>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel