From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VRk5d-00085z-WF
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 10:41:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VRjzN-0007hA-8y
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 10:35:03 -0400
Received: from mail-yh0-x22d.google.com ([2607:f8b0:4002:c01::22d]:36007)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VRjzN-0007gd-4j
	for qemu-devel@nongnu.org; Thu, 03 Oct 2013 10:34:49 -0400
Received: by mail-yh0-f45.google.com with SMTP id i72so655370yha.32
	for <qemu-devel@nongnu.org>; Thu, 03 Oct 2013 07:34:47 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <524D807D.4070205@twiddle.net>
Date: Thu, 03 Oct 2013 07:34:37 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <524D6838.5080607@linaro.org>
In-Reply-To: <524D6838.5080607@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL
	instruction.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Will Newton <will.newton@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 10/03/2013 05:51 AM, Will Newton wrote:
> +                    case 0: /* eq: Z */
> +                        tcg_gen_movcond_i64(TCG_COND_EQ, ftmp3, cpu_ZF, zero,
> +                                            ftmp1, ftmp2);
> +                        break;

Does this compile when configured with --enable-debug?

It shouldn't, since movcond_i64 takes 5 _i64 variables,
and your comparison variables are _i32.


r~